Web: Provide accurate actionable steps with duplicate db name error#26116
Merged
Web: Provide accurate actionable steps with duplicate db name error#26116
Conversation
608aee5 to
e5f104a
Compare
ryanclark
approved these changes
May 12, 2023
Member
ryanclark
left a comment
There was a problem hiding this comment.
Just a couple of minor comments
Member
There was a problem hiding this comment.
I think Boolean() here is redundant as you're using &&
Contributor
Author
There was a problem hiding this comment.
i get this type error if i don't cast it:
Argument of type 'string' is not assignable to parameter of type 'boolean'
Contributor
|
I will take a look on Monday. |
gzdunek
reviewed
May 15, 2023
Contributor
|
Nit: I think that long error messages look better as sentences: (but if other error messages are not written this way then let it stay as it is) |
e5f104a to
5391fc1
Compare
Contributor
Author
i left it as is, i think we want errors to be all lower cased |
gzdunek
approved these changes
May 16, 2023
82974cb to
f42374f
Compare
This was referenced May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of discover work to improve rds flow:
Screenshot
note: the tctl command is actually
tctl rm db/<dbname>i just took the screenshot before i caught itSelf-hosted, duplicate db with a database server:

Self-hosted, duplicated db (no db server)

aws rds, dup db (no db server)

aws rds, dup db with a db server

disable row:
