Skip to content

Add pprof diagnostics endpoints to tbot#26106

Merged
strideynet merged 2 commits intomasterfrom
strideynet/tbot-pprof
May 12, 2023
Merged

Add pprof diagnostics endpoints to tbot#26106
strideynet merged 2 commits intomasterfrom
strideynet/tbot-pprof

Conversation

@strideynet
Copy link
Copy Markdown
Contributor

Closes #26087

When -d --diag-addr 127.0.0.1:1337 a HTTP server is set to listen with the pprof debug handlers mounted.

Comment thread lib/tbot/tbot.go
mux.HandleFunc("/debug/pprof/trace", pprof.Trace)
mux.Handle("/", http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusNotFound)
msg := "404 - Not Found\n\nI'm a little tbot,\nshort and stout,\nthe page you seek,\nis not about."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, lol

Copy link
Copy Markdown
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget docs

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from camscale May 11, 2023 21:48
@strideynet strideynet added this pull request to the merge queue May 11, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 11, 2023
@strideynet strideynet added this pull request to the merge queue May 12, 2023
Merged via the queue into master with commit 72ac01b May 12, 2023
@strideynet strideynet deleted the strideynet/tbot-pprof branch May 12, 2023 07:59
@public-teleport-github-review-bot
Copy link
Copy Markdown

@strideynet See the table below for backport results.

Branch Result
branch/v11 Failed
branch/v12 Create PR
branch/v13 Create PR

strideynet added a commit that referenced this pull request May 12, 2023
* Add pprof diagnostics endpoints to `tbot`

* Add test coverage for diag-addr
strideynet added a commit that referenced this pull request May 15, 2023
* Add pprof diagnostics endpoints to `tbot`

* Add test coverage for diag-addr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Machine ID: tbot allow pprof endpoints to be enabled

3 participants