[v12] Fixes a SharedDirectoryAnnounce incompatibility#26091
Merged
ibeckermayer merged 2 commits intobranch/v12from May 16, 2023
Merged
[v12] Fixes a SharedDirectoryAnnounce incompatibility#26091ibeckermayer merged 2 commits intobranch/v12from
ibeckermayer merged 2 commits intobranch/v12from
Conversation
* Fixes a SharedDirectoryAnnounce incompatibility The SharedDirectoryAnnounce message was changed to remove an unnecessary completionID field, however this change caused an incompatibility between the proxy and previous versions of the wds. This commit reverts that specific change and adds notes to the code explaining the situation. The original change is here: https://github.com/gravitational/teleport/pull/25260/files#diff-98a4bee57beb7f007614e4810d2cf8413bddf48484c8aad6dd0756a218797c36R677-R678 * changes completionId to discard * adds discard bit to sda.Encode to make fuzz tests happy
ibeckermayer
requested review from
klizhentas,
r0mant,
russjones and
zmb3
as code owners
github-actions
Bot
added
application-access
audit-log
github-actions
Bot
requested review from
alexfornuto,
codingllama,
espadolini,
kimlisa,
ptgott,
ravicious,
strideynet,
tigrato and
tobiaszheller
|
@ibeckermayer - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
Contributor
|
Targeting the wrong branch? |
Contributor
Author
Indeed |
ibeckermayer
removed request for
alexfornuto,
espadolini,
klizhentas,
ptgott,
r0mant,
ravicious,
russjones,
strideynet,
tigrato,
tobiaszheller and
xinding33
zmb3
approved these changes
May 11, 2023
codingllama
approved these changes
May 11, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from kimlisa
strideynet
approved these changes
May 12, 2023
tigrato
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #25931 to branch/v12