Skip to content

Allow non moderated sessions when no-auth connection exists#26074

Merged
tigrato merged 2 commits intomasterfrom
tigrato/allow-exec-sessions-no-auth
May 15, 2023
Merged

Allow non moderated sessions when no-auth connection exists#26074
tigrato merged 2 commits intomasterfrom
tigrato/allow-exec-sessions-no-auth

Conversation

@tigrato
Copy link
Copy Markdown
Contributor

@tigrato tigrato commented May 11, 2023

This PR builds the last bit required to allow users to create remote
Kubernetes sessions when Auth connection is not available or is
intermittent.

This PR allows a user to continue with the interactive session when the
session does not require any moderation.

PR #25202 deferred the proxy cert creation for cases where it's
mandatory (kube agent or proxy running version <=12.x.x) which allowed
any user to perform simple requests against a Kubernetes cluster even
when the cluster Auth server is not operational. On top of that, this PR
allows a user to request an interactive session against a pod when auth
connectivity is not required as long as the session isn't moderated.

Part of #25541
Related to #25202
Implements #26014


Integration tests to formally test the behavior and regressions will be added in a separate PR.

@tigrato tigrato force-pushed the tigrato/allow-exec-sessions-no-auth branch from a1bb2dc to 4758f9f Compare May 12, 2023 15:39
@tigrato tigrato requested review from AntonAM and rosstimothy May 12, 2023 15:58
@tigrato tigrato marked this pull request as ready for review May 12, 2023 15:58
tigrato added 2 commits May 15, 2023 09:08
This PR builds the last bit required to allow users to create remote
kubernetes sessions when Auth connection is not available or is
intermitent.

This PR allows a user to continue with the interactive session when the
session does not require any moderation.

PR #25202 deferred the proxy cert creation for cases where the it's
mandatory (kube agent or proxy running version <=12.x.x) which allowed
any user to perform simple requests against a Kubernetes cluster even
when the cluster Auth server is not operational. On top of that, this PR
allows a user to request an interactive session against a pod when auth
conectivity is not required as long as the session isn't moderated.

Part of #25541
Related to #25202
Implements #26014
@tigrato tigrato force-pushed the tigrato/allow-exec-sessions-no-auth branch from d16af08 to a0ac7d0 Compare May 15, 2023 08:08
@tigrato tigrato added this pull request to the merge queue May 15, 2023
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 15, 2023
@tigrato tigrato added this pull request to the merge queue May 15, 2023
Merged via the queue into master with commit 306f875 May 15, 2023
@tigrato tigrato deleted the tigrato/allow-exec-sessions-no-auth branch May 15, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants