Fix Helm chart Join token secret creation#26055
Merged
Conversation
github-actions
Bot
requested review from
alexfornuto,
codingllama,
ptgott,
r0mant,
xinding33 and
zmb3
tigrato
force-pushed
the
tigrato/fix-helm-secret-creation
branch
3 times, most recently
from
de86c28 to
33b7ac2
Compare
tigrato
force-pushed
the
tigrato/fix-helm-secret-creation
branch
from
33b7ac2 to
4298406
Compare
r0mant
approved these changes
May 11, 2023
ptgott
approved these changes
May 11, 2023
public-teleport-github-review-bot
Bot
removed request for
alexfornuto,
codingllama,
hugoShaka,
marcoandredinis,
webvictim,
xinding33 and
zmb3
Contributor
|
If I understand correctly, this is a breaking change (well, it was introduced by the previous PR). I think we will want to highlight this in the v13 changelog. |
tigrato
force-pushed
the
tigrato/fix-helm-secret-creation
branch
from
423b035 to
ac01013
Compare
hugoShaka
approved these changes
May 12, 2023
webvictim
approved these changes
May 12, 2023
tigrato
added a commit
that referenced
this pull request
May 12, 2023
* Fix Helm chart Join token secret creation Since #20763 was merged, we lost the ability of the chart reusing the externally created secrets for join token. This PR changes the logic and allows to control the secret creation using the `joinTokenSecret.create` boolean and the secret name with `joinTokenSecret.name`. Fixes #20763 * Add changelog
tigrato
added a commit
that referenced
this pull request
May 12, 2023
* Fix Helm chart Join token secret creation Since #20763 was merged, we lost the ability of the chart reusing the externally created secrets for join token. This PR changes the logic and allows to control the secret creation using the `joinTokenSecret.create` boolean and the secret name with `joinTokenSecret.name`. Fixes #20763 * Add changelog
|
does anyone know when this new version will be released? |
Contributor
Author
Hey @yidongw, we plan to release it this week |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #20763 was merged, we lost the ability of the chart to reuse the externally created secrets for the join token.
This PR changes the logic and allows control of the secret creation using the
joinTokenSecret.createboolean and the secret name withjoinTokenSecret.name.Fixes #26002