TLS Routing behind ALB: tsh kube join#26047
Closed
greedy52 wants to merge 5 commits intotigrato/enable-kindfrom
Closed
TLS Routing behind ALB: tsh kube join#26047greedy52 wants to merge 5 commits intotigrato/enable-kindfrom
tsh kube join#26047greedy52 wants to merge 5 commits intotigrato/enable-kindfrom
Conversation
github-actions
Bot
added
size/md
tsh
greedy52
commented
May 11, 2023
Contributor
Author
There was a problem hiding this comment.
moved from integration/proxy, no change.
greedy52
changed the title
tsh kube jointsh kube join
tigrato
force-pushed
the
tigrato/enable-kind
branch
from
01e11e7 to
e4abfba
Compare
tigrato
force-pushed
the
tigrato/enable-kind
branch
from
e4abfba to
49b9af9
Compare
greedy52
force-pushed
the
STeve/21870_tsh_kube_join
branch
from
683230d to
57849fc
Compare
greedy52
force-pushed
the
STeve/21870_tsh_kube_join
branch
from
57849fc to
13a74af
Compare
greedy52
changed the title
tsh kube jointsh kube join
tigrato
force-pushed
the
tigrato/enable-kind
branch
2 times, most recently
from
82b08c4 to
ec37d32
Compare
greedy52
removed request for
AntonAM,
EdwardDowling,
nklaassen,
smallinsky and
tigrato
Contributor
Author
|
splitting this to two smaller PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue
This PR:
tsh kube login/credentialsto give better messages when detected ALBtsh kube joinsupportComing next in separate PR(s):
tsh kubectl/tsh kube execto start local proxy automaticallyNote this PR currently stacks on #25624 which fixes kube integration test. Will rebase once it's merged to master.