[docs] Include File Transfers in moderated sessions docs#26032
Merged
[docs] Include File Transfers in moderated sessions docs#26032
Conversation
github-actions
Bot
requested review from
alexfornuto,
ptgott,
r0mant,
xinding33 and
zmb3
zmb3
reviewed
May 10, 2023
| After enough approvals have been given to satisfy the policy (the same policy to start the session), the file transfer | ||
| will automatically begin. | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
It might also make sense to have an FAQ or troubleshooting page with what happens when you try to tsh scp when moderation is required.
Contributor
Author
There was a problem hiding this comment.
Good idea, will add!
Contributor
There was a problem hiding this comment.
having some screen shots would be an added bonus.
Contributor
There was a problem hiding this comment.
Are file approve/denies logged as audit log entries? good to note if they are.
Contributor
Author
There was a problem hiding this comment.
Not yet, have an upcoming PR that will add the audit logs and will update the docs then. The file transfer itself is still audited as usual
stevenGravy
reviewed
May 12, 2023
Co-authored-by: Steven Martin <steven@goteleport.com>
stevenGravy
reviewed
May 12, 2023
Co-authored-by: Steven Martin <steven@goteleport.com>
ptgott
approved these changes
May 12, 2023
Contributor
ptgott
left a comment
ptgott
left a comment
There was a problem hiding this comment.
Left some minor suggestions
stevenGravy
approved these changes
May 15, 2023
avatus
added a commit
that referenced
this pull request
May 15, 2023
* [docs] Include File Transfers in moderated sessions docs * Fix typo * Add note in tsh scp reference * Update docs/pages/access-controls/guides/moderated-sessions.mdx Co-authored-by: Steven Martin <steven@goteleport.com> * Add screenshot * Update docs/pages/access-controls/guides/moderated-sessions.mdx Co-authored-by: Steven Martin <steven@goteleport.com> * Update moderated-sessions.mdx --------- Co-authored-by: Steven Martin <steven@goteleport.com>
avatus
added a commit
that referenced
this pull request
May 15, 2023
…6265) * [docs] Include File Transfers in moderated sessions docs * Fix typo * Add note in tsh scp reference * Update docs/pages/access-controls/guides/moderated-sessions.mdx * Add screenshot * Update docs/pages/access-controls/guides/moderated-sessions.mdx * Update moderated-sessions.mdx --------- Co-authored-by: Steven Martin <steven@goteleport.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs for the implementation of #23546