fix: use errors.Is for all EOF comparisons#26012
Merged
Conversation
This commit updates all `err == io.EOF` comparisons to use
`errors.Is(err, io.EOF)`. This is necessary when the error may have been
wrapped and fixes at least one current breakage (in `tsh request ls`).
`golang.org/x/tools/refactor/eg` was very handy for this, I used the
following template:
```go
package teleport
import (
"errors"
"io"
)
func before(err error) bool { return err == io.EOF }
func after(err error) bool { return errors.Is(err, io.EOF) }
```
github-actions
Bot
added
audit-log
Contributor
Author
|
@zmb3 @rosstimothy I think this is probably the best quick fix for #25996. I can add test coverage for |
zmb3
approved these changes
May 10, 2023
rosstimothy
approved these changes
May 10, 2023
public-teleport-github-review-bot
Bot
removed request for
espadolini and
marcoandredinis
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
nklaassen
added a commit
that referenced
this pull request
May 10, 2023
Backport #26012 to branch/v12 This commit updates all `err == io.EOF` comparisons to use `errors.Is(err, io.EOF)`. This is necessary when the error may have been wrapped and fixes at least one current breakage (in `tsh request ls`). `golang.org/x/tools/refactor/eg` was very handy for this, I used the following template: ```go package teleport import ( "errors" "io" ) func before(err error) bool { return err == io.EOF } func after(err error) bool { return errors.Is(err, io.EOF) } ```
nklaassen
added a commit
that referenced
this pull request
May 10, 2023
Backport #26012 to branch/v13 This commit updates all `err == io.EOF` comparisons to use `errors.Is(err, io.EOF)`. This is necessary when the error may have been wrapped and fixes at least one current breakage (in `tsh request ls`). `golang.org/x/tools/refactor/eg` was very handy for this, I used the following template: ```go package teleport import ( "errors" "io" ) func before(err error) bool { return err == io.EOF } func after(err error) bool { return errors.Is(err, io.EOF) } ```
This was referenced May 10, 2023
nklaassen
added a commit
that referenced
this pull request
May 10, 2023
Backport #26012 to branch/v11 This commit updates all `err == io.EOF` comparisons to use `errors.Is(err, io.EOF)`. This is necessary when the error may have been wrapped and fixes at least one current breakage (in `tsh request ls`). `golang.org/x/tools/refactor/eg` was very handy for this, I used the following template: ```go package teleport import ( "errors" "io" ) func before(err error) bool { return err == io.EOF } func after(err error) bool { return errors.Is(err, io.EOF) } ```
nklaassen
added a commit
that referenced
this pull request
May 10, 2023
Backport #26012 to branch/v13 This commit updates all `err == io.EOF` comparisons to use `errors.Is(err, io.EOF)`. This is necessary when the error may have been wrapped and fixes at least one current breakage (in `tsh request ls`). `golang.org/x/tools/refactor/eg` was very handy for this, I used the following template: ```go package teleport import ( "errors" "io" ) func before(err error) bool { return err == io.EOF } func after(err error) bool { return errors.Is(err, io.EOF) } ```
nklaassen
added a commit
that referenced
this pull request
May 10, 2023
Backport #26012 to branch/v11 This commit updates all `err == io.EOF` comparisons to use `errors.Is(err, io.EOF)`. This is necessary when the error may have been wrapped and fixes at least one current breakage (in `tsh request ls`). `golang.org/x/tools/refactor/eg` was very handy for this, I used the following template: ```go package teleport import ( "errors" "io" ) func before(err error) bool { return err == io.EOF } func after(err error) bool { return errors.Is(err, io.EOF) } ```
nklaassen
added a commit
that referenced
this pull request
May 10, 2023
Backport #26012 to branch/v12 This commit updates all `err == io.EOF` comparisons to use `errors.Is(err, io.EOF)`. This is necessary when the error may have been wrapped and fixes at least one current breakage (in `tsh request ls`). `golang.org/x/tools/refactor/eg` was very handy for this, I used the following template: ```go package teleport import ( "errors" "io" ) func before(err error) bool { return err == io.EOF } func after(err error) bool { return errors.Is(err, io.EOF) } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates all
err == io.EOFcomparisons to useerrors.Is(err, io.EOF). This is necessary when the error may have been wrapped and fixes at least one current breakage (intsh request ls).golang.org/x/tools/refactor/egwas very handy for this, I used the following template:I will backport manually by re-running
eg