billing banner appears on application load#26007
Merged
michellescripts merged 1 commit intomasterfrom May 11, 2023
Merged
Conversation
ryanclark
approved these changes
May 10, 2023
michellescripts
force-pushed
the
michelle/billing-banner-fix
branch
from
2060403 to
ebffe99
Compare
ravicious
approved these changes
May 11, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from rudream
michellescripts
force-pushed
the
michelle/billing-banner-fix
branch
from
ebffe99 to
3bc37cb
Compare
This was referenced May 11, 2023
michellescripts
added a commit
that referenced
this pull request
May 11, 2023
michellescripts
added a commit
that referenced
this pull request
May 11, 2023
michellescripts
added a commit
that referenced
this pull request
May 11, 2023
michellescripts
added a commit
that referenced
this pull request
May 11, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the billing banner was not displaying on application load, would show up on subsequent updates (page view, tab change).
Cause We need to check two values to determine if the billing banner should display:
cfg.oss.isUsageBasedBillingandctx.getFeatureFlags().billing. in e/Mainctx.getFeatureFlags().billingwas returning false on load. This is because we callctx.initin ./Main (a child component)Solution
cfg.oss.isUsageBasedBillingand if that is true, passes billing banner to ./Mainctx.getFeatureFlags().billingand if that is true, passes the billing banner to the banner listTeleport.e implementation: https://github.com/gravitational/teleport.e/pull/1356
supports: https://github.com/gravitational/cloud/issues/3536