[v12] Use os.UserHomeDir where possible#25998
Merged
zmb3 merged 2 commits intobranch/v12from May 11, 2023
Merged
Conversation
r0mant
approved these changes
May 10, 2023
zmb3
changed the title
Joerger
approved these changes
May 11, 2023
In #24156 we removed a lot of unnecessary calls to user.Current, which can take a long time in Active Directory environments. This commit removes a few other uses of user.Current where we were doing a full user lookup only to find the user's home directory, which is usually more readily available via the environment.
This fixes a bug introduced in #25950
zmb3
force-pushed
the
bot/backport-25950-branch/v12
branch
from
91bfd51 to
eb83c4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #25950 and #26010 to branch/v12