usagereporter: split the ssh_port session start into ssh_port_v2, k8s_port#25987
Merged
espadolini merged 1 commit intomasterfrom May 11, 2023
Merged
usagereporter: split the ssh_port session start into ssh_port_v2, k8s_port#25987espadolini merged 1 commit intomasterfrom
ssh_port session start into ssh_port_v2, k8s_port#25987espadolini merged 1 commit intomasterfrom
Conversation
gabrielcorado
approved these changes
May 10, 2023
timothyb89
approved these changes
May 10, 2023
Same goes for foo_sessions in UserActivityReport.
espadolini
force-pushed
the
espadolini/prehog-ssh-port
branch
from
a589dd6 to
2356ca2
Compare
|
@espadolini See the table below for backport results.
|
This was referenced May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
portaudit event is used to indicate both SSH port forwarding andkubectl port-forward, but we were grouping both under a type ofssh_portforSessionStartEvent. This PR splits the two, and adds two fields toUserActivityReport(ssh_port_v2_sessionsandkube_port_sessions) to count them for the aggregating usage reporter.Depends on gravitational/cloud#4479 for proto changes.