[v13] Add events to cta clicks (#25325)#25986
Merged
mcbattirola merged 1 commit intobranch/v13from May 10, 2023
Merged
Conversation
* (wip) add unlock feature button to support page * Fix typo * (wip) add locked feature join session * Improve session join style * Add session join lock button * Remove hover on locked join menu * Update copy * Only show `join as...` when appropriate * (wip) * Make ButtonLockedFeature theme sensitive * Remove debug stuff * Adjust feature button height * Fix session join button on locked * Remove unused import * typo * Add link to cta button * Remove teams flag * Add cta service * Update snapshots * Lock button style * Add cta to context * Rename cta to ctaService * Stories and tests * Add comments clarifying that ctas are not used currently * add showActiveSessionsCTA to useSessions * Licenses * Lint license * Remove commented out code * Add missing types * Replace cta service for an object with cta on context * Fix menu hack * small refactor in styled stuff * Update SessionJoinBtn to use master code * Snapshot update * Add events to cta clicks * rebase * revert e ref update * Revert e change * Update proto message to start at 1 * Use enum from proto files instead of rewriting * Improve comments on usageevents.proto cta enum * Fix import * Fix type errs * Add comments * Rename CtaEvents > CtaEvent * Copy the CtaEvent enum instead of importing from proto * Add back blank line * Fix import order * Update proto files * Add TODO comment
gzdunek
approved these changes
May 10, 2023
espadolini
approved these changes
May 10, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from michellescripts
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #25325 to v13