Web: Allow aws svg icon to take on the themes main color#25961
Merged
Conversation
kimlisa
changed the title
zmb3
approved these changes
May 9, 2023
kimlisa
force-pushed
the
lisa/theme-specific-aws-icon
branch
from
434756f to
e201739
Compare
kimlisa
requested review from
rudream
and removed request for
ibeckermayer and
ravicious
rudream
approved these changes
May 9, 2023
- Fixes the previous aws icon blending in with light theme - Remove duplicate sources of aws icon - Create stories for svg's icon, preferring them over existing font icons from icomoon
kimlisa
force-pushed
the
lisa/theme-specific-aws-icon
branch
from
e201739 to
c6e8064
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
backport to v12 not required, forgot that we don't have light theme support for v12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
existing font icons from icomoon
enterprise changes: https://github.com/gravitational/teleport.e/pull/1349
previously:
after change (no changes for dark theme):