Search bar: Take cluster filter into account when listing offline clusters#25910
Merged
Search bar: Take cluster filter into account when listing offline clusters#25910
Conversation
gzdunek
approved these changes
May 10, 2023
avatus
approved these changes
May 10, 2023
ryanclark
approved these changes
May 11, 2023
ravicious
force-pushed
the
ravicious/filter-offline
branch
from
5392f8c to
c64b21d
Compare
|
@ravicious See the table below for backport results.
|
|
@ravicious See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a cluster filter was selected, the search bar ignored it when listing offline clusters, leading to a situations like this one:
Here the cluster filter limits the search only to the teleport-local cluster. But the message below says that the other cluster was excluded from the search due to having an expired cert.
This PR takes care of that by making sure that we only list a single offline cluster if the cluster filter is selected.