[v13] Makefile: cache go env values#25894
Merged
marcoandredinis merged 1 commit intobranch/v13from May 9, 2023
Merged
Conversation
Spawning shells is expensive for Makefile targets. We use the `OS` and `ARCH` variables in a lot of places. They come from spawning a subshell and then executing `go env GOOS` or `go env GOARCH`. So, everytime we need them, we spawn a subshells. Just parsing the Makefile adds quite some time, even if the target itself is fast. This PR caches those values, so that we only need to spawn a subshell once per execution. Tests show that running `make print-version` is now much faster: Using linux: drop from 56s to 0.240s Using MacOS M1: drop from 291ms to 119ms YMMV
marcoandredinis
force-pushed
the
auto-backport/25870-to-branch/v13
branch
from
47dccf9 to
15b69b0
Compare
marcoandredinis
changed the title
go env values
espadolini
approved these changes
May 9, 2023
zmb3
approved these changes
May 9, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from camscale
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #25870 to branch/v13