Skip to content

Remove code related to the command bar from Connect#25882

Merged
ravicious merged 3 commits intomasterfrom
ravicious/remove-search-bar-flag
May 9, 2023
Merged

Remove code related to the command bar from Connect#25882
ravicious merged 3 commits intomasterfrom
ravicious/remove-search-bar-flag

Conversation

@ravicious
Copy link
Copy Markdown
Member

@ravicious ravicious commented May 9, 2023

Removed stuff:

  • the search bar feature flag that we briefly used
  • src/ui/services/quickInput/
  • src/ui/QuickInput/
  • commandLauncher code that was related to the command bar
    • This includes the tsh-ssh command which is no longer used anywhere.

It also documents which stuff is deprecated and can be removed in >14.0. I didn't take care of this right now because this can be done down the road and I didn't want to spend more time on this right now.

@ravicious ravicious marked this pull request as ready for review May 9, 2023 11:04
@github-actions github-actions Bot requested review from kimlisa and ryanclark May 9, 2023 11:05
@ravicious ravicious requested review from gzdunek and removed request for kimlisa May 9, 2023 11:05
Copy link
Copy Markdown
Member

@ryanclark ryanclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

beautiful

@ravicious ravicious added this pull request to the merge queue May 9, 2023
Merged via the queue into master with commit 3112431 May 9, 2023
@ravicious ravicious deleted the ravicious/remove-search-bar-flag branch May 9, 2023 14:00
@public-teleport-github-review-bot
Copy link
Copy Markdown

@ravicious See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants