Provide client address information in transport request#25853
Merged
Conversation
Contributor
Author
|
Not directly related but same are of code, issue: https://github.com/gravitational/teleport-private/issues/618 |
espadolini
reviewed
May 9, 2023
Contributor
There was a problem hiding this comment.
Should this be if (dreq.ClientSrcAddr == "" || dreq.ClientDstAddr == "") && p.sconn != nil? Or maybe we could only fill the missing field?
Contributor
Author
There was a problem hiding this comment.
Changed according to offline discussion.
If client address information is missing in dial request, we take it from the ssh connection. It's needed for correctly propagating IP information of users connecting to auth server through proxy tunnel listener.
AntonAM
force-pushed
the
anton/tunnel-client-src
branch
from
f77634e to
4b4bc0f
Compare
jentfoo
approved these changes
May 9, 2023
espadolini
approved these changes
May 10, 2023
greedy52
approved these changes
May 10, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This was referenced May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If client address information is missing in dial request, we take it from the parent ssh connection, otherwise we end up with localhost/Proxy address as client source address. It's needed for correctly propagating IP information of users connecting to auth server through proxy tunnel listener (fx command
tctl statusetc).