Skip to content

[v13] Remove not a valid Unix login logging #25838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosstimothy merged 1 commit into from
May 9, 2023
Merged

[v13] Remove not a valid Unix login logging #25838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions lib/services/role.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,19 +270,20 @@ func validateRule(r types.Rule) error {
}

func filterInvalidUnixLogins(candidates []string) []string {
// The tests for `ApplyTraits()` require that an empty list is nil
// rather than a 0-size slice, and I don't understand the potential
// knock-on effects of changing that, so the default value is `nil`
output := []string(nil)
var output []string

for _, candidate := range candidates {
if !cstrings.IsValidUnixUser(candidate) {
log.Debugf("Skipping login %v, not a valid Unix login.", candidate)
if cstrings.IsValidUnixUser(candidate) {
// A valid variable was found in the traits, append it to the list of logins.
output = append(output, candidate)
continue
}

// A valid variable was found in the traits, append it to the list of logins.
output = append(output, candidate)
// Log any invalid logins which were added by a user but ignore any
// Teleport internal logins which are known to be invalid.
if candidate != teleport.SSHSessionJoinPrincipal && !strings.HasPrefix(candidate, "no-login-") {
log.Debugf("Skipping login %v, not a valid Unix login.", candidate)
}
}
return output
}
Expand Down