Remove not a valid Unix login logging

[rosstimothy]

No description provided.

[fspmarshall]

nit: this is theoretically useful if users are actually adding invalid unix logins... maybe we should just be skipping the log for invalid unix logins that begin with -teleport (e.g. -teleport-internal-join, -teleport-nologin-deadbeef, etc)?

[rosstimothy]

nit: this is theoretically useful if users are actually adding invalid unix logins... maybe we should just be skipping the log for invalid unix logins that begin with -teleport (e.g. -teleport-internal-join, -teleport-nologin-deadbeef, etc)?

I think the majority of hits on this end up being in the from no-login-<UUID> though:

They are quite frequent too:

[rosstimothy]

@fspmarshall I've made the logging conditional to ignore Teleport internal invalid logins. I think we should perhaps audit and remove the no-login-<uuid> that is added to the auditor role as well. I don't see anything actively consuming it and I believe roles support not having any logins defined. There is nothing stopping users from removing the generated login from the auditor role either, so anything dependent on it existing is likely to not work properly any way.

[public-teleport-github-review-bot]

@rosstimothy See the table below for backport results.

Branch	Result
branch/v11	Create PR
branch/v12	Create PR
branch/v13	Create PR