Show errors if fetching ParameterPicker suggestions fails#25703
Merged
Show errors if fetching ParameterPicker suggestions fails#25703
Conversation
We want to reuse it in ParameterPicker.
ravicious
commented
May 5, 2023
| /** | ||
| * IconAndContent is supposed to be used within InteractiveItem & NonInteractiveItem. | ||
| */ | ||
| export function IconAndContent( |
Member
Author
There was a problem hiding this comment.
I didn't have better idea for a name. 🤕
Contributor
There was a problem hiding this comment.
I tried to come up with a suggestion and I couldn't either. Sounds like its good enough to me
Member
Author
There was a problem hiding this comment.
I moved the story from ActionPicker.story.tsx to just results.story.tsx. We could have separate stories for ActionPicker and ParameterPicker but I'm not sure if it makes sense at the moment, we just have a single item from ParameterPicker here. I like being able to see them all at once.
ravicious
force-pushed
the
ravicious/param-picker-err
branch
from
9408fb0 to
78182ba
Compare
avatus
approved these changes
May 5, 2023
| /** | ||
| * IconAndContent is supposed to be used within InteractiveItem & NonInteractiveItem. | ||
| */ | ||
| export function IconAndContent( |
Contributor
There was a problem hiding this comment.
I tried to come up with a suggestion and I couldn't either. Sounds like its good enough to me
gzdunek
approved these changes
May 5, 2023
ryanclark
approved these changes
May 8, 2023
|
@ravicious See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParameterPickerused to have no error handling when fetching db usernames. Any errors would be simply swallowed. This is a leftover from the prototype version which this PR addresses. Now the error will show up in a similar fashion to resource search errors inActionPicker.Resetting the active item on pick
The first commit is unrelated to the PR but I wanted to squeeze it in.
Before this change, the active item index would not change after picking a filter, making the selection stay in place.
Screen recording of previous behavior
active-item.mov
I don't think is what the typical user expects – if I select a filter, I think I'd rather have the active item reset to the first one – selecting a filter has totally reorganized the results lists.
Without this change it was also possible for the selection to stay the same after selecting an SSH server and switching from selecting a resource to selecting a login.