[v12] [Web] Update theme in v12#25650
Merged
rudream merged 1 commit intobranch/v12from May 5, 2023
Merged
Conversation
rudream
changed the title
kimlisa
approved these changes
May 5, 2023
ravicious
approved these changes
May 5, 2023
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
I went through Connect stories and the places for which we don't have stories (mostly access requests and some of the panels in the top bar) and everything looks ok!
rudream
force-pushed
the
yassine/12/theme-updates
branch
from
c1cd3ec to
60928be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ecounterpart: https://github.com/gravitational/teleport.e/pull/1300Purpose
In #23539, the theme was refactored in preparation for implementing the new themes that would be added in v13. However, when implementing the themes, a few further changes had to be made to the theme definitions.
This PR updates the theme definitions in v12 so that all the colour fields defined in the v13+ theme are included. This is in order to make components written in v13+ easier to backport to this version. The new fields added in this PR (such as
spotBackground) are not currently in use anywhere in this version, but are here to make backporting future components that might use them easier. The fields that have been renamed (such as the text colors) have had their usages in this version updated to match the new names.