Skip to content

[v13] Add specific message for network errors on app launch (Web UI) #25607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabrielcorado merged 4 commits into from
May 5, 2023
Merged

[v13] Add specific message for network errors on app launch (Web UI) #25607

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fe4a1ea
feat(web): add network error message for app launch
gabrielcorado May 3, 2023
9c3e95c
Update web/packages/teleport/src/AppLauncher/AppLauncher.tsx
gabrielcorado May 3, 2023
23ee0bf
refactor(web): update error message
gabrielcorado May 3, 2023
a303010
chore(web): fix linter
gabrielcorado May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions web/packages/teleport/src/AppLauncher/AppLauncher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,12 @@ export function AppLauncher() {
const queryParams = new URLSearchParams(search);

const createAppSession = useCallback(async (params: UrlLauncherParams) => {
let fqdn = params.fqdn;
const port = location.port ? `:${location.port}` : '';

try {
let fqdn = params.fqdn;
if (!fqdn) {
const app = await service.getAppFqdn(params);

fqdn = app.fqdn;
}

Expand All @@ -48,7 +49,6 @@ export function AppLauncher() {
params.arn = decodeURIComponent(params.arn);
}

const port = location.port ? `:${location.port}` : '';
const session = await service.createAppSession(params);

await fetch(`https://${fqdn}${port}/x-teleport-auth`, {
Expand All @@ -72,7 +72,11 @@ export function AppLauncher() {
window.location.replace(`https://${fqdn}${port}${path}`);
} catch (err) {
let statusText = 'Something went wrong';
if (err instanceof Error) {

if (err instanceof TypeError) {
// `fetch` returns `TypeError` when there is a network error.
statusText = `Unable to access "${fqdn}". This may happen if your Teleport Proxy is using untrusted or self-signed certificate. Please ensure Teleport Proxy service uses valid certificate or access the application domain directly (https://${fqdn}${port}) and accept the certificate exception from your browser.`;
} else if (err instanceof Error) {
statusText = err.message;
}

Expand Down