Improve chart documentation and best practices#25601
Merged
Conversation
github-actions
Bot
requested review from
alexfornuto,
ptgott,
ryanclark,
xinding33 and
zmb3
hugoShaka
commented
May 3, 2023
| NOTE: For certificates to be provisioned, you must also install cert-manager (https://cert-manager.io/docs/) and configure an appropriate | ||
| Issuer with access to your DNS provider to handle DNS01 challenges (https://cert-manager.io/docs/configuration/acme/dns01/#supported-dns01-providers) | ||
|
|
||
| For more information, please see the Helm guides in the Teleport docs (https://goteleport.com/docs/kubernetes-access/helm/guides/) |
Contributor
Author
There was a problem hiding this comment.
Note for reviewers: I dropped this condition because it was broken for cert mounting through tls and we are doing checks at other places
tigrato
approved these changes
May 4, 2023
marcoandredinis
approved these changes
May 4, 2023
webvictim
approved these changes
May 5, 2023
ptgott
approved these changes
May 5, 2023
public-teleport-github-review-bot
Bot
removed request for
alexfornuto,
ryanclark,
xinding33 and
zmb3
hugoShaka
force-pushed
the
hugo/improve-chart-ux
branch
from
bcc0abb to
654c658
Compare
|
@hugoShaka See the table below for backport results.
|
hugoShaka
added a commit
that referenced
this pull request
May 9, 2023
hugoShaka
added a commit
that referenced
this pull request
May 9, 2023
hugoShaka
added a commit
that referenced
this pull request
May 9, 2023
hugoShaka
added a commit
that referenced
this pull request
May 9, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mitigates two frequently reported UX issues causing support load:
teleportVersionOverrideto control the Teleport version, which causes compatibility issues. The chart is versioned with Teleport, and the versions should match unless they know what they are doingscratchmode while they could just pass a configuration override throughteleportConfig. As they are not familiar with how auth/proxy are clustering, this leads to broken setups.Thanks @tigrato and @webvictim for reporting the issues