Support UI methods for user groups, label match user groups in API.#25559
Merged
Support UI methods for user groups, label match user groups in API.#25559
Conversation
UI methods have been added to User Groups to support the enterprise Okta service. This will allow groups to be queried and displayed on the new access request page appropriately. Additionally, after adding group labels to roles, the access checking was not added to the appropriate user groups endpoints in auth_with_roles. This has been added to ensure that users can only see the user groups they're supposed to see when requesting access.
avatus
approved these changes
May 3, 2023
Contributor
avatus
left a comment
avatus
left a comment
There was a problem hiding this comment.
Left a small comment but rest looks fine
r0mant
approved these changes
May 3, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from ravicious
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI methods have been added to User Groups to support the enterprise Okta service. This will allow groups to be queried and displayed on the new access request page appropriately.
Additionally, after adding group labels to roles, the access checking was not added to the appropriate user groups endpoints in auth_with_roles. This has been added to ensure that users can only see the user groups they're supposed to see when requesting access.