Make ProtoPostgres support PROXY protocol#25526
Merged
Conversation
timothyb89
approved these changes
May 3, 2023
r0mant
reviewed
May 3, 2023
Collaborator
r0mant
left a comment
r0mant
left a comment
There was a problem hiding this comment.
In general lgtm but I would like @smallinsky or @greedy52 to look over this as well to make sure there won't be any hidden side-effects of this.
r0mant
requested review from
greedy52 and
smallinsky
and removed request for
tigrato
greedy52
approved these changes
May 3, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from smallinsky
greedy52
reviewed
May 3, 2023
AntonAM
force-pushed
the
anton/proxyline-postgres-protocol
branch
from
c95644e to
e690419
Compare
This was referenced May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multiplexer when protocol was determined to be
ProtoPostgreswe didn't include proxy line in the returned connection, which lead to problems with IP pinning (client IP was not matching).