opentelemetry dependency updates#25497
Merged
rosstimothy merged 7 commits intomasterfrom May 18, 2023
Merged
Conversation
This was referenced May 2, 2023
This was referenced May 8, 2023
rosstimothy
force-pushed
the
nklaassen/otel-updates
branch
3 times, most recently
from
98bbbb7 to
a9df587
Compare
This was referenced May 15, 2023
Closed
rosstimothy
force-pushed
the
nklaassen/otel-updates
branch
from
a9df587 to
21a1460
Compare
github-actions
Bot
added
size/sm
tsh
rosstimothy
approved these changes
May 15, 2023
codingllama
approved these changes
May 15, 2023
Contributor
There was a problem hiding this comment.
This is a package name? o.O
public-teleport-github-review-bot
Bot
removed the request for review
from atburke
Bumps [go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.40.0 to 0.41.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.40.0...zpages/v0.41.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://github.com/open-telemetry/opentelemetry-go) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-go@v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This test modifies the global trace provider and a race can reliably
detected with the latest version of the oteltrace library.
This doesn't have much impact on the test runtime, which is dominated by
a single subtest.
```
--- PASS: TestTraceProvider (1.07s)
--- PASS: TestTraceProvider/not_sampling_prevents_exporting (0.00s)
--- PASS: TestTraceProvider/spans_exported_with_gRPC+TLS (0.00s)
--- PASS: TestTraceProvider/spans_exported_with_gRPC (0.00s)
--- PASS: TestTraceProvider/spans_exported_with_HTTP (0.00s)
--- PASS: TestTraceProvider/spans_exported_with_HTTPS (1.06s)
```
rosstimothy
force-pushed
the
nklaassen/otel-updates
branch
from
21a1460 to
9fd049f
Compare
Contributor
|
looks like there is still a race 😞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is still at least one outstanding race condition in theedit: thanks @rosstimothy for taking care of thosetshtests that I'll need to fix