Install Scripts: add updater package#25479
Conversation
marcoandredinis
force-pushed
the
marco/agent_updater_install_scripts
branch
2 times, most recently
from
c10848a to
6a647fc
Compare
marcoandredinis
force-pushed
the
marco/agent_updater_install_scripts
branch
from
6a647fc to
12afada
Compare
|
|
||
| PACKAGE_LIST="{{ .TeleportPackage }}" | ||
| if [[ "{{ .AutomaticUpgrades }}" == "true" ]]; then | ||
| PACKAGE_LIST="${PACKAGE_LIST} {{ .TeleportPackage }}-updater" |
There was a problem hiding this comment.
Don't we need to install only xxx-updater package? I think it will pull teleport package as dependency?
@hugoShaka @fheinecke Am I wrong?
There was a problem hiding this comment.
It does 👍
https://apt.releases.development.teleport.dev/ubuntu/dists/bionic/stable/v13/binary-amd64/Packages
We can remove it, however I would like to clarify something first:
teleport-ent-updater depends on teleport
teleport and teleport-ent both provide teleport.
So, when we try to install only teleport-ent-updater which package is going to be pulled? Is it teleport or teleport-ent?
There was a problem hiding this comment.
Yes, but we don't want the teleport-ent package to be deleted if the user wants to uninstall the updater. IMO it makes sense to mark both as wanted, so teleport-ent won't be auto-removed.
There was a problem hiding this comment.
@hugoShaka In your documentation guide we instruct people to just apt install teleport-ent-updater. Is that for scenario when you already have an agent and want to add updater to it?
@fheinecke I think teleport-ent-updater should depend on teleport-ent, not teleport. Can we update that?
There was a problem hiding this comment.
Is that for scenario when you already have an agent and want to add updater to it?
Yes, the guide explains how to enroll an existing agent into automatic updates
There was a problem hiding this comment.
I think teleport-ent-updater should depend on teleport-ent, not teleport. Can we update that?
@r0mant it has been (tested before I went on vacation, see https://github.com/gravitational/teleport.e/pull/1177)
There was a problem hiding this comment.
we don't want the
teleport-entpackage to be deleted if the user wants to uninstall the updater.
I'll keep both packages then 👍
|
|
||
| PACKAGE_LIST="{{ .TeleportPackage }}" | ||
| if [[ "{{ .AutomaticUpgrades }}" == "true" ]]; then | ||
| PACKAGE_LIST="${PACKAGE_LIST} {{ .TeleportPackage }}-updater" |
There was a problem hiding this comment.
Is there any condition where {{ .TeleportPackage }} is set to anything but teleport-ent-updater? We don't currently publish separate packages for OSS and this will error if it's set to teleport-updater.
There was a problem hiding this comment.
It won't 👍
AutomaticUpgrades comes from:
automaticUpgrades := feats.AutomaticUpgrades && modules.GetModules().BuildType() == modules.BuildEnterprise
So, it will only be true for Enterprise builds
I left a comment so that we can comeback to this and simplify the condition only:
// TODO(marco): remove BuildType check when teleport-upgrade (oss) package is available in apt/yum repos
|
@fheinecke Friendly ping |
|
@marcoandredinis See the table below for backport results.
|
* Install Scripts: add updater package (#25479) * Install Node Script: respect version variable (#25885) We were always installing the latest version available even if the requested version was different This PR changes the installation command and the version is now pinned to the one received in the `TELEPORT_VERSION` variable. * revert teleport-upgrade installation
4 participants
This was manually tested and worked as expected.
Fixes #24628 (comment)