Add IsUsageBased to features and send it to web UI#25465
Merged
mcbattirola merged 8 commits intomasterfrom May 4, 2023
Merged
Conversation
michellescripts
approved these changes
May 2, 2023
kimlisa
approved these changes
May 3, 2023
timothyb89
approved these changes
May 3, 2023
Contributor
timothyb89
left a comment
timothyb89
left a comment
There was a problem hiding this comment.
LGTM with @kimlisa's comments resolved.
public-teleport-github-review-bot
Bot
removed the request for review
from ravicious
…tirola/add-usage-based-billing-flag
…tirola/add-usage-based-billing-flag
|
@mcbattirola See the table below for backport results.
|
mcbattirola
added a commit
that referenced
this pull request
May 8, 2023
* Add IsUsageBased to features and send to web UI * Update flag name * Improve comment * Add comments and improve field name * Remove duplicated property
mcbattirola
added a commit
that referenced
this pull request
May 8, 2023
* Add IsUsageBased to features and send to web UI * Update flag name * Improve comment * Add comments and improve field name * Remove duplicated property
mcbattirola
added a commit
that referenced
this pull request
May 9, 2023
mcbattirola
added a commit
that referenced
this pull request
May 9, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
isUsageBasedflag to theFeaturesstruct and sends it to the web UI.This flag will be used to hide/show billing-related stuff in the web UI. Currently, the flag is not used.
This flag is set by this PR: https://github.com/gravitational/teleport.e/pull/1260