Conversation
tigrato
force-pushed
the
tigrato/disable-kube-if-not-supported-by-license
branch
2 times, most recently
from
309b40f to
1fc9f4d
Compare
tigrato
changed the title
kubernetes_service if cluster is not licensed for KubeRoleRemoteProxy to list 'kube_servers` when cluster isn't licensed for Kubernetes
tigrato
changed the title
RoleRemoteProxy to list 'kube_servers` when cluster isn't licensed for KubernetesRoleRemoteProxy to list kube_servers when cluster isn't licensed for Kubernetes
fspmarshall
approved these changes
May 2, 2023
tigrato
force-pushed
the
tigrato/disable-kube-if-not-supported-by-license
branch
from
1fc9f4d to
9e81235
Compare
When a remote proxy retrieves the list of kube clusters available in the remote cluster and the remote cluster isn't licensed, the request fails because the remote proxy role was not whitelisted. This PR does not return the license error if the requester is a local or remote server. This PR also disables the `kubernetes_service` on startup if the cluster is not licensed for Kubernetes access. This prevents the process from being in the degraded state when trying to upsert the `kube_server` via heartbeat.
tigrato
force-pushed
the
tigrato/disable-kube-if-not-supported-by-license
branch
from
9e81235 to
3f42c4b
Compare
mdwn
approved these changes
May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a remote proxy retrieves the list of kube clusters available in the
remote cluster and the remote cluster isn't licensed, the request fails because the remote proxy role was not
whitelisted. This PR does not return the license error if the requester is a local or remote server.
This PR also disables the
kubernetes_serviceon startup if the cluster isnot licensed for Kubernetes access.
This prevents the process from being in the degraded state when trying to
upsert the
kube_servervia heartbeat.