Skip to content

WebDiscover: Put back IamPolicy screen and some tweaks#25438

Merged
kimlisa merged 6 commits intomasterfrom
lisa/discover-tweaks
May 2, 2023
Merged

WebDiscover: Put back IamPolicy screen and some tweaks#25438
kimlisa merged 6 commits intomasterfrom
lisa/discover-tweaks

Conversation

@kimlisa
Copy link
Copy Markdown
Contributor

@kimlisa kimlisa commented May 1, 2023 •
edited
Loading

resolves #22130

Final tweaking for the new RDS flow:

  • fixed bug where rds enroll event returned an error b/c it wouldn't accept a selectedResourcecount of zero (it will be zero when this screen has an error)
  • put back IamPolicy screen
  • fix typo (mispelling asterisks)
  • remove port 443 for aws integration flow from every step and in animations
  • replace hard coded colors affecting discover, with defined colors from theme

cc @marcoandredinis

@kimlisa kimlisa requested a review from ryanclark May 1, 2023 20:43
@github-actions github-actions Bot requested a review from gzdunek May 1, 2023 20:43
@kimlisa kimlisa mentioned this pull request May 1, 2023
Closed
@kimlisa kimlisa enabled auto-merge May 2, 2023 16:15
r0mant
r0mant approved these changes May 2, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@public-teleport-github-review-bot public-teleport-github-review-bot Bot removed the request for review from gzdunek May 2, 2023 16:19
@kimlisa kimlisa added this pull request to the merge queue May 2, 2023
Merged via the queue into master with commit 7c11721 May 2, 2023
@kimlisa kimlisa deleted the lisa/discover-tweaks branch May 2, 2023 16:51
@public-teleport-github-review-bot
Copy link
Copy Markdown

public-teleport-github-review-bot Bot commented May 2, 2023

@kimlisa See the table below for backport results.

Branch Result
branch/v12 Failed
branch/v13 Create PR

kimlisa added a commit that referenced this pull request May 2, 2023
@kimlisa
WebDiscover: Put back IamPolicy screen and some tweaks (#25438)
d307d95 
* Let count be 0 (it will be zero on error)

* Put back IamPolicy screen with updated links

* Fix typo

* Remove port for 443 from very beginning of AWS integration flow

in addition fix inconsistent animation JSON policy

* Remove hard coded colors and remove unnecessary border
@kimlisa kimlisa mentioned this pull request May 2, 2023
Merged
@kimlisa kimlisa mentioned this pull request May 3, 2023
Merged
kimlisa added a commit that referenced this pull request May 4, 2023
@kimlisa
WebDiscover: Put back IamPolicy screen and some tweaks (#25438)
cdad9a7
kimlisa added a commit that referenced this pull request May 6, 2023
@kimlisa
WebDiscover: Put back IamPolicy screen and some tweaks (#25438)
04e28f8
kimlisa added a commit that referenced this pull request May 6, 2023
@kimlisa
[v12] WebDiscover: Enroll RDS Databases and Hookup RDS flow (#25604)
70a5c9c 
* WebDiscover: Create Enroll a RDS Database Screen (#24509)

* WebDiscover: Finish implementing Enroll Database Screen (#24710)

* WebDiscover: Hookup AWS RDS Flow (#24873)

* WebDiscover: Put back IamPolicy screen and some tweaks (#25438)

* Remove unused get url

* Update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r0mant r0mant r0mant approved these changes

@ryanclark ryanclark ryanclark approved these changes

Assignees

No one assigned

Labels

size/sm ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Discover] Day 2 "Enroll RDS Resource"

3 participants

@kimlisa @r0mant @ryanclark