[v13] WebDiscover: Hookup AWS RDS Flow (#24873)#25435
Merged
kimlisa merged 1 commit intobranch/v13from May 1, 2023
Merged
Conversation
* Clean up aws oidc integration instructions * Change ResourceSpec icon type from ReactElement to string When storing state into location URL, it doesn't allow storing ReactElement, so I changed the icon element into string that refers to the correct icon. Also adds rds aurora tiles to Select Resources screen. * Fix the expected backend aws status value for RDS list * For RDS list, allow refreshing the table Helpful when user makes changes to the RDS instance (eg. tags) and needs to get the most up to date listing * Update rds db setup access text info * Make create database dialog more consistent btwn states * Fix label matching Previously we required the agent matcher labels be an exact match of registered db labels otherwise we prevented the user from deploying an agent (which was wrong). Now the only requirement is that the matcher labels are all able to match against registered db labels. * Implement resuming discover flow from where user left of * Enable integration access and rds flow * Strip 443 ports from cluster uri * Use the labels returned from polling db instaed * Various touch ups - Make label matching error less confusing by showing error upon user trying to generate command - Make label messaging clearer - Emit errors when failing to fetch rds dbs * Address CR and update test
avatus
approved these changes
May 1, 2023
r0mant
approved these changes
May 1, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from ryanclark
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport #24873 to branch/v13