Disallow OktaAssignment deletion from tctl.#25432
Merged
Conversation
tctl no longer allows OktaAssignment deletion.
zmb3
approved these changes
May 1, 2023
Collaborator
zmb3
left a comment
zmb3
left a comment
There was a problem hiding this comment.
Code change looks fine, but the commit message is missing the why.
r0mant
approved these changes
May 1, 2023
This was referenced May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tctl no longer allows OktaAssignment deletion as OktaAssignments are internal objects that should only be managed by users.
Note: This still allows retrieval of Okta assignments from tctl. Let me know if you feel strongly about excising this as well.