Skip to content

[v13] Get safe destination address when proxying to cluster #25417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntonAM merged 1 commit into from
May 1, 2023
Merged

[v13] Get safe destination address when proxying to cluster #25417

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/srv/transport/transportv1/transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,12 @@ func (s *Service) ProxyCluster(stream transportv1pb.TransportService_ProxyCluste
return trace.BadParameter("unable to find peer")
}

conn, err := s.cfg.Dialer.DialSite(ctx, req.Cluster, p.Addr, s.cfg.LocalAddr)
clientDst, err := getDestinationAddress(p.Addr, s.cfg.LocalAddr)
if err != nil {
return trace.Wrap(err, "could get not client destination address; listener address %q, client source address %q", s.cfg.LocalAddr.String(), p.Addr.String())
}

conn, err := s.cfg.Dialer.DialSite(ctx, req.Cluster, p.Addr, clientDst)
if err != nil {
return trace.Wrap(err, "failed dialing cluster %q", req.Cluster)
}
Expand Down