Get safe destination address when proxying to cluster#25405
Merged
Conversation
AntonAM
added
bug
test-plan-problem
Joerger
approved these changes
May 1, 2023
timothyb89
approved these changes
May 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we're proxying connection from grpc we rely on listener address for getting client destination address, that is used in PROXY header. But if listener's address is unspecified we need to replace it with loopback. Getting safe address was added to
ProxySSH, but was missing fromProxyClusterfunction in the transportv1 which lead to failed connections if proxy listener mode wasseparateCloses #25365