[Web] Fix audit log date matcher error#25344
Merged
Conversation
avatus
approved these changes
Apr 28, 2023
zmb3
reviewed
Apr 28, 2023
ryanclark
approved these changes
May 2, 2023
Member
ryanclark
left a comment
ryanclark
left a comment
There was a problem hiding this comment.
LGTM after a test has been added
rudream
force-pushed
the
yassine/fix-audit-error
branch
from
654f94c to
f520355
Compare
kimlisa
reviewed
May 5, 2023
zmb3
approved these changes
May 5, 2023
kimlisa
approved these changes
May 6, 2023
Collaborator
|
@rudream let's get this one merged |
rudream
force-pushed
the
yassine/fix-audit-error
branch
from
a7899d6 to
4b1c2dc
Compare
This was referenced May 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes a console error and UI freezes when searching through the audit log caused by the date matcher.
Implementation
The error was occurring because the
timebeing passed into the matcher function was in a string ISO format, whichdate-fnsfunctions don't support. Converting it toDateresolved the issue.