Return friendly errors when sessions are prevented due to a lock#25342
Merged
rosstimothy merged 1 commit intomasterfrom May 2, 2023
Merged
Return friendly errors when sessions are prevented due to a lock#25342rosstimothy merged 1 commit intomasterfrom
rosstimothy merged 1 commit intomasterfrom
Conversation
Session failures resulting from a lock being enforced were returning the EOF that the MFA connection attempt got from the Auth server instead of the friendly error which gets returned from the node via the direct connection attempt. The direct connection attempt errors now take precendent over the MFA connection errors when an EOF is returned from the MFA connection attempt. Fixes #25321
zmb3
approved these changes
May 1, 2023
Contributor
Author
gabrielcorado
approved these changes
May 1, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
|
@rosstimothy See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session failures resulting from a lock being enforced were returning the EOF that the MFA connection attempt got from the Auth server instead of the friendly error which gets returned from the node via the direct connection attempt.
The direct connection attempt errors now take precendent over the MFA connection errors when an EOF is returned from the MFA connection attempt.
Fixes #25321