[docs] Amazon Athena guide for Application Access#25329
Merged
Conversation
ptgott
reviewed
May 2, 2023
Contributor
ptgott
left a comment
ptgott
left a comment
There was a problem hiding this comment.
I really like the new partials!
Just left a few comments.
ptgott
approved these changes
May 5, 2023
Contributor
|
@greedy52 Does this require backporting? |
alexfornuto
approved these changes
May 16, 2023
Contributor
alexfornuto
left a comment
alexfornuto
left a comment
There was a problem hiding this comment.
Approved with some suggestions.
| </TabItem> | ||
|
|
||
| <TabItem label="Using AWS CLI"> | ||
| Create a file with the following trust policy: |
Contributor
There was a problem hiding this comment.
Suggest explicitly telling the reader to replace the value of aws-account-id here and in the next tab. You can use a Var component with the same name outside of the code blocks if you want.
public-teleport-github-review-bot
Bot
removed request for
r0mant,
smallinsky,
xinding33 and
zmb3
smallinsky
approved these changes
May 17, 2023
greedy52
added a commit
that referenced
this pull request
May 18, 2023
* [docs] Amazon Athena guide for Application Access * review comments * update cspell.json * Alex's comment and fix lint
greedy52
added a commit
that referenced
this pull request
May 19, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted the following from the existing DynamoDB guide, with some small edits so they can be shared
docs/pages/includes/application-access/aws-database-access-cli.mdxdocs/pages/includes/application-access/aws-database-access-console.mdxdocs/pages/includes/application-access/aws-database-agent-permission.mdxdocs/pages/includes/application-access/aws-database-create-iam-role.mdxdocs/pages/includes/application-access/aws-database-prerequisites.mdxdocs/pages/includes/application-access/aws-database-role-mapping.mdxdocs/pages/includes/application-access/aws-database-start-app-service.mdxMost new content is in
### Using other Athena applicationssection.