Skip to content

UI improvements for empty search input#25314

Merged
ravicious merged 3 commits intomasterfrom
ravicious/empty-state
May 4, 2023
Merged

UI improvements for empty search input#25314
ravicious merged 3 commits intomasterfrom
ravicious/empty-state

Conversation

@ravicious
Copy link
Copy Markdown
Member

  • <TypeToSearchItem> used to be displayed only when the input was empty after selecting all available filters and it used to say "Type something to search". Now it's displayed whenever the input is empty and says "Enter space-separated search terms. Select a filter to narrow down the search."
  • As soon as the user selects a filter, we fetch a couple of "preview" resources matching the filter.
    • This makes the search bar immediately respond to user interaction. Before we'd not show anything after selecting a filter, the search bar would wait for further input before showing any results.

@github-actions github-actions Bot requested review from avatus and ryanclark April 28, 2023 09:52
@ravicious ravicious requested review from gzdunek and removed request for ryanclark April 28, 2023 09:53
@ravicious ravicious enabled auto-merge April 28, 2023 14:25
@ravicious ravicious added this pull request to the merge queue May 4, 2023
Merged via the queue into master with commit 48bf3a9 May 4, 2023
@ravicious ravicious deleted the ravicious/empty-state branch May 4, 2023 13:46
@public-teleport-github-review-bot
Copy link
Copy Markdown

@ravicious See the table below for backport results.

Branch Result
branch/v13 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants