[v13] Fix cluster alerts timeout#25299
Merged
zmb3 merged 1 commit intobranch/v13from Apr 28, 2023
Merged
Conversation
tsh shows clusters alerts for both `tsh login` and `tsh status`. We intentionally used a short (500ms) timeout to avoid slowing down `tsh status` which was previously an "offline" command. As a side effect, cluster alerts would not always show on login if they took longer than 500ms to fetch. This change ensures that we always wait for cluster alerts to come back for `tsh login`, but we still enforce a short timeout for the `tsh status` command. (The timeout was increased slightly since the context now wraps the entire command and not just the cluster alerts call) Fixes #25239
github-actions
Bot
added
tctl
rosstimothy
approved these changes
Apr 27, 2023
ibeckermayer
approved these changes
Apr 28, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #25261 to branch/v13