Use the correct emitter in auth.TLSServer#25265
Merged
espadolini merged 1 commit intomasterfrom Apr 27, 2023
Merged
Conversation
rosstimothy
approved these changes
Apr 27, 2023
marcoandredinis
approved these changes
Apr 27, 2023
public-teleport-github-review-bot
Bot
removed request for
nklaassen and
timothyb89
|
@espadolini See the table below for backport results.
|
This was referenced Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an explicit implementation of
apievents.Emittertoauth.Server, which delegates the call toEmitAuditEventto theemitterof the auth server; this is then used to pass the auth server itself to theauth.TLSServeras the emitter, which lets future calls to(*auth.Server).SetEmitteractually take effect on anything that grabs the emitter from theauth.TLSServer(as it's the case with all the plugins).Fixes gravitational/teleport.e#1221