Merged
Conversation
zmb3
approved these changes
Apr 27, 2023
jentfoo
approved these changes
Apr 27, 2023
This was referenced Apr 28, 2023
Tener
added a commit
that referenced
this pull request
Apr 28, 2023
* Add FuzzDecode covering tdp protocol. * Add FuzzDecode to oss-fuzz * Limit PNG2Frame size. * Fix decodeSharedDirectoryAnnounce incorrectly consuming 4 extra bytes.
Tener
added a commit
that referenced
this pull request
Apr 28, 2023
* Add FuzzDecode covering tdp protocol. * Limit PNG2Frame size. * Fix decodeSharedDirectoryAnnounce incorrectly consuming 4 extra bytes.
zmb3
pushed a commit
that referenced
this pull request
Apr 28, 2023
Tener
added a commit
that referenced
this pull request
May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds fuzzing for TDP protocol's
Decodefunction and fixes two issues uncovered by the fuzzer.PNG2Framewould allocate slice of ofpngLengthbytes. The declared length could be near the end ofuint32range, which would cause the overflow in21+pngLengthexpression, making the actual buffer very small:png2frame := make([]byte, 21+pngLength). Subsequentlypng2frame[1:5]would panic.decodeSharedDirectoryAnnouncewould consume 4 initial bytes to decodecompletionIDvalue, discarded by the function as it is not a member ofSharedDirectoryAnnouncestruct.SharedDirectoryAnnounce.Encode()does not save the 4 bytes for this field. This is likely a copy-paste error fromSharedDirectoryInfoRequestwhich does have theCompletionIDfield.