Conversation
github-actions
Bot
requested review from
alexfornuto,
camscale,
ptgott,
r0mant,
rosstimothy,
xinding33 and
zmb3
lxea
force-pushed
the
lxea/instance-state-error-message
branch
2 times, most recently
from
61663c1 to
92d6e76
Compare
zmb3
reviewed
Apr 27, 2023
lxea
force-pushed
the
lxea/instance-state-error-message
branch
2 times, most recently
from
4f4be99 to
86586f1
Compare
ptgott
approved these changes
Apr 27, 2023
Contributor
|
@lxea Does this need to be backported? |
camscale
approved these changes
Apr 28, 2023
lxea
force-pushed
the
lxea/instance-state-error-message
branch
from
86586f1 to
cf65ad2
Compare
alexfornuto
reviewed
Apr 28, 2023
lxea
force-pushed
the
lxea/instance-state-error-message
branch
from
cf65ad2 to
159c9b5
Compare
r0mant
reviewed
May 2, 2023
| if trace.IsNotFound(err) { | ||
| var aErr awserr.Error | ||
| if errors.As(err, &aErr) && aErr.Code() == ssm.ErrCodeInvalidInstanceId { | ||
| s.Log.WithError(err).Error("Invalid instance ID found. This can happen if the instance does not have a running SSM agent registered with the SSM endpoint (may require reinstalling the SSM Agent, or giving the instance IAM permissions to receive SSM commands), or the discovery instance does not have permissions to access the node.") |
Collaborator
There was a problem hiding this comment.
Let's rephrase the error message to:
SSM RunCommand on instance i-xyz123 failed with ErrCodeInvalidInstanceId. Make sure that the instance has AmazonSSMManagedInstanceCore policy assigned. Also check that SSM agent is running and registered with the SSM endpoint on that instance and try restarting or reinstalling it in case of issues. See <link to AWS reference page> for more details.
Contributor
Author
There was a problem hiding this comment.
Ive updated this with the link but there doesnt seem to be a way to get the actual instances it failed with in the message, but they're included in the error
lxea
force-pushed
the
lxea/instance-state-error-message
branch
from
159c9b5 to
2f487f9
Compare
r0mant
approved these changes
May 4, 2023
public-teleport-github-review-bot
Bot
removed request for
rosstimothy and
xinding33
This was referenced May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #24176