athena audit logs - integration tests by tobiaszheller · Pull Request #25248 · gravitational/teleport

tobiaszheller · 2023-04-27T08:35:43Z

Part of https://github.com/gravitational/teleport.e/issues/894
RFD: https://github.com/gravitational/teleport/blob/master/rfd/0118-scalable-audit-logs.md

test.Suite used by other backend was modified in few places because:

in few places ID was missing or not used as UUID
searchEvents accepts parameters in UTC time, but not everywhere in test cases it was passed as UTC.

Depends on #26053

tobiaszheller · 2023-05-11T08:59:37Z

@smallinsky @marcoandredinis @rosstimothy PTAL

marcoandredinis

LGTM
I think there's a typo in SearchSessionEvensBySessionID (Evens vs Events)

marcoandredinis · 2023-05-15T07:13:09Z

💅
There's a require.Eventually that could be used here

public-teleport-github-review-bot · 2023-05-16T09:32:45Z

@tobiaszheller See the table below for backport results.

Branch	Result
branch/v13	Failed

public-teleport-github-review-bot · 2023-05-18T08:10:41Z

@tobiaszheller See the table below for backport results.

Branch	Result
branch/v13	Failed

github-actions Bot requested review from marcoandredinis and smallinsky April 27, 2023 08:36

github-actions Bot added audit-log Issues related to Teleports Audit Log size/md labels Apr 27, 2023

tobiaszheller commented Apr 27, 2023

View reviewed changes

Comment thread lib/events/test/suite.go Outdated

tobiaszheller commented Apr 27, 2023

View reviewed changes

Comment thread lib/events/test/suite.go

tobiaszheller commented Apr 27, 2023

View reviewed changes

Comment thread lib/events/test/suite.go

tobiaszheller requested a review from rosstimothy April 27, 2023 09:07

smallinsky reviewed Apr 27, 2023

View reviewed changes

Comment thread lib/events/athena/integration_test.go Outdated

Comment thread lib/events/athena/integration_test.go

Comment thread lib/events/test/suite.go Outdated

Comment thread lib/events/athena/integration_test.go Outdated

Comment thread lib/events/athena/integration_test.go Outdated

smallinsky requested review from smallinsky April 27, 2023 10:22

rosstimothy reviewed May 3, 2023

View reviewed changes

Comment thread lib/events/test/suite.go

Comment thread lib/events/test/suite.go Outdated

Comment thread lib/events/athena/integration_test.go Outdated

Comment thread lib/events/athena/integration_test.go Outdated

Comment thread lib/events/athena/integration_test.go

tobiaszheller commented May 11, 2023

View reviewed changes

Comment thread lib/events/test/suite.go Outdated

tobiaszheller requested a review from rosstimothy May 11, 2023 08:59

rosstimothy reviewed May 12, 2023

View reviewed changes

Comment thread lib/events/athena/consumer.go Outdated

Comment thread lib/events/athena/integration_test.go Outdated

Comment thread lib/events/athena/integration_test.go Outdated

Comment thread lib/events/test/suite.go Outdated

tobiaszheller requested a review from rosstimothy May 12, 2023 13:25

rosstimothy approved these changes May 12, 2023

View reviewed changes

marcoandredinis approved these changes May 15, 2023

View reviewed changes

smallinsky approved these changes May 15, 2023

View reviewed changes

athena audit logs - integration tests

5aff6f3

tobiaszheller force-pushed the tobiaszheller/auditevents-athena-integrationtests branch from 667fd34 to 5aff6f3 Compare May 15, 2023 10:05

tobiaszheller enabled auto-merge May 15, 2023 10:19