fix connecting to agentless leaf nodes#25206
Merged
capnspacehook merged 2 commits intomasterfrom May 2, 2023
Merged
Conversation
capnspacehook
force-pushed
the
capnspacehook/fix-agentless-leaf-nodes
branch
2 times, most recently
from
a363e94 to
1021b91
Compare
capnspacehook
force-pushed
the
capnspacehook/fix-agentless-leaf-nodes
branch
2 times, most recently
from
94c04b3 to
9add8c0
Compare
rosstimothy
reviewed
Apr 26, 2023
Contributor
rosstimothy
left a comment
rosstimothy
left a comment
There was a problem hiding this comment.
Can we add test coverage to prevent any regressions?
capnspacehook
force-pushed
the
capnspacehook/fix-agentless-leaf-nodes
branch
5 times, most recently
from
49afbc8 to
4eed39e
Compare
r0mant
reviewed
May 2, 2023
r0mant
requested review from
strideynet
and removed request for
gabrielcorado and
lxea
strideynet
approved these changes
May 2, 2023
espadolini
reviewed
May 2, 2023
capnspacehook
force-pushed
the
capnspacehook/fix-agentless-leaf-nodes
branch
2 times, most recently
from
a5d3725 to
9a7ac6e
Compare
espadolini
reviewed
May 2, 2023
Pass user and role information to Auth server signing OpenSSH cert so avoid user/role lookup errors if the target node is on a leaf cluster. Also use role and trait information from the current connection rather than the backend to support role impersonation.
capnspacehook
force-pushed
the
capnspacehook/fix-agentless-leaf-nodes
branch
from
9a7ac6e to
732997d
Compare
avatus
approved these changes
May 2, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from fspmarshall
|
@capnspacehook See the table below for backport results.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass user and role information to Auth server signing OpenSSH cert so avoid user/role lookup errors if the target node is on a leaf cluster. Also use role and trait information from the current connection rather than the backend to support role impersonation.
Fixes #25068.
Fixes #25083.