[v13] Retry search in Connect if current workspace cert has expired#25179
Merged
ravicious merged 10 commits intobranch/v13from Apr 28, 2023
Merged
[v13] Retry search in Connect if current workspace cert has expired#25179ravicious merged 10 commits intobranch/v13from
ravicious merged 10 commits intobranch/v13from
Conversation
The state setter coming from useState is always stable. https://legacy.reactjs.org/docs/hooks-reference.html#usestate
lockOpen worked great when we were concerned only about user interaction with a modal closing the search bar as well. However, in the next commit I'm going to add a login modal that's shown if the search fails with a retryable error. In that scenario, pressing Enter in the modal wouldn't work, as it would be captured by the window listener that ResultList adds. To work around this problem, I refactored lockOpen into pauseUserInteraction. It still works pretty much the same way. But then instead of having checking isLockedOpen in the close function, we have a new addWindowEventListener function. addWindowEventListener automatically removes the listener after pauseUserInteraction is called. This solves both the problem of closing the modal and the problem of using the enter key in the modal.
gzdunek
approved these changes
Apr 26, 2023
avatus
approved these changes
Apr 26, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from ryanclark
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #24880 to branch/v13