docs: clarify host labeling for Windows desktops#25172
Merged
Conversation
github-actions
Bot
requested review from
alexfornuto,
ptgott,
r0mant and
xinding33
Collaborator
Author
|
This is pretty confusing, let me know if I need to do a better job of explaining it. |
ptgott
reviewed
Apr 26, 2023
| environment: prod | ||
| ``` | ||
|
|
||
| The regular expression provided in the `match` rule above is applied to the desktop's |
Contributor
There was a problem hiding this comment.
I think it would help to include examples for:
- A desktop discovered via LDAP
- A host that is statically defined
Collaborator
Author
There was a problem hiding this comment.
Updated, let me know if you think that's an improvement.
Label rules apply against the desktop's addr for statically defined hosts, which includes the trailing :3389. Label rules apply against the desktop's hostname for desktops discovered via LDAP.
zmb3
force-pushed
the
zmb3/desktop-label-docs-updates
branch
from
c936109 to
ef4e2f1
Compare
ptgott
approved these changes
May 1, 2023
r0mant
approved these changes
May 2, 2023
public-teleport-github-review-bot
Bot
removed request for
alexfornuto and
xinding33
This was referenced May 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Label rules apply against the desktop's addr for statically defined hosts, which includes the trailing :3389.
Label rules apply against the desktop's hostname for desktops discovered via LDAP.