Merged
Conversation
The Okta assignment statuses have been simplfieid so that there's only a status on the Okta assignment object itself and the number of states is reduced.
r0mant
approved these changes
Apr 25, 2023
espadolini
approved these changes
Apr 26, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from GavinFrazar
tigrato
approved these changes
Apr 26, 2023
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
mdwn
added a commit
that referenced
this pull request
Apr 26, 2023
The Okta assignment statuses have been simplfieid so that there's only a status on the Okta assignment object itself and the number of states is reduced.
mdwn
added a commit
that referenced
this pull request
Apr 26, 2023
* Simplify Okta assignment statuses. (#25166) The Okta assignment statuses have been simplfieid so that there's only a status on the Okta assignment object itself and the number of states is reduced. * Use backend clock instead of config clock because it doesn't exist in v12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Okta assignment statuses have been simplified so that there's only a status on the Okta assignment object itself and the number of states is reduced.
Note: As the OktaAssignments aren't actually used anywhere yet, I'm electing to do some major GRPC level surgery so that we're not stuck with the legacy surrounding the old states. Let me know if you have any objections.
All this is really doing is moving up the assignment status up to the OktaAssignment rather than the OktaAction.