fix session recordings from Web UI to agentless nodes having name set as node UUID#25109
Merged
capnspacehook merged 1 commit intomasterfrom Apr 25, 2023
Merged
Conversation
atburke
approved these changes
Apr 24, 2023
strideynet
approved these changes
Apr 25, 2023
public-teleport-github-review-bot
Bot
removed the request for review
from espadolini
capnspacehook
deleted the
capnspacehook/fix-agentless-web-recording-names
branch
|
@capnspacehook See the table below for backport results.
|
Collaborator
|
No way to test this? |
Contributor
Author
|
Tried to create a test but for now more it's more trouble than it's worth for this small change. Adding a check to the existing agentless integration test is non-trivial as it requires waiting until a session recording is uploaded, and the uploader is asynchronous and difficult to wait on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25072.