Fix underlying reader not a terminal issues#25102
Merged
Conversation
github-actions
Bot
added
size/sm
tsh
Joerger
commented
Apr 24, 2023
Joerger
force-pushed
the
joerger/catch-underlying-reader-not-a-terminal-error
branch
3 times, most recently
from
7028e35 to
2317b78
Compare
probakowski
approved these changes
Apr 25, 2023
zmb3
reviewed
Apr 25, 2023
Joerger
force-pushed
the
joerger/catch-underlying-reader-not-a-terminal-error
branch
from
2317b78 to
dd7d7e0
Compare
public-teleport-github-review-bot
Bot
removed the request for review
from gzdunek
Joerger
force-pushed
the
joerger/catch-underlying-reader-not-a-terminal-error
branch
5 times, most recently
from
3868b27 to
79027b9
Compare
* Improve error messages when attempting to login without a terminal * Skip MOTD acknowledement when logging in without a terminal (headless, sso) * When attempting re-login without a terminal, make a debug log and return the original error * Return access denied error on unexpected handshake failures in tsh proxy ssh
Joerger
force-pushed
the
joerger/catch-underlying-reader-not-a-terminal-error
branch
from
67b3f3d to
2d62a0c
Compare
Joerger
force-pushed
the
joerger/catch-underlying-reader-not-a-terminal-error
branch
from
2d62a0c to
db49a53
Compare
Joerger
deleted the
joerger/catch-underlying-reader-not-a-terminal-error
branch
Joerger
added a commit
that referenced
this pull request
Apr 27, 2023
* * Use Stderr during headless login to fix rsync compatibility * Improve error messages when attempting to login without a terminal * Skip MOTD acknowledement when logging in without a terminal (headless, sso) * When attempting re-login without a terminal, make a debug log and return the original error * Return access denied error on unexpected handshake failures in tsh proxy ssh * Fix TestProxySSH test and add it to the flaky test detector testsToSkip list.
Joerger
added a commit
that referenced
this pull request
Apr 27, 2023
* * Use Stderr during headless login to fix rsync compatibility * Improve error messages when attempting to login without a terminal * Skip MOTD acknowledement when logging in without a terminal (headless, sso) * When attempting re-login without a terminal, make a debug log and return the original error * Return access denied error on unexpected handshake failures in tsh proxy ssh * Fix TestProxySSH test and add it to the flaky test detector testsToSkip list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #24810
Closes #24925