fix github url formatting#25089
Merged
fspmarshall merged 1 commit intomasterfrom Apr 24, 2023
Merged
Conversation
hugoShaka
approved these changes
Apr 24, 2023
espadolini
approved these changes
Apr 24, 2023
|
@fspmarshall See the table below for backport results.
|
fspmarshall
added a commit
that referenced
this pull request
Apr 24, 2023
fspmarshall
added a commit
that referenced
this pull request
Apr 24, 2023
fspmarshall
added a commit
that referenced
this pull request
Apr 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where github logins would fail if a user was part of more than 30 teams (the default page size). This issue was caused by an improperly formatted callback URL, which ended up containing a duplicate path separator (
//).Unit test was added to cover this specific scenario, and manual testing was performed to ensure that this change fixes the issue and that multi-page team lists are now loadable.